_task_graph.py 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353
  1. """Pure task-tree operations used by :mod:`agent.orchestration.coordinator`.
  2. The task ledger remains owned and committed by ``TaskCoordinator``. This
  3. module only mutates the in-memory aggregate handed to it; it never performs
  4. I/O, acquires locks, or commits state on its own.
  5. """
  6. from __future__ import annotations
  7. from dataclasses import asdict
  8. from typing import Any, Dict, List, Optional, Sequence, Tuple
  9. from .errors import OrchestrationError, TaskConflict
  10. from .models import (
  11. DecisionAction,
  12. PlannerDecision,
  13. TaskAttempt,
  14. TaskLedger,
  15. TaskRecord,
  16. TaskSpec,
  17. TaskStatus,
  18. ValidationReport,
  19. ValidationRunStatus,
  20. ValidationVerdict,
  21. json_values,
  22. new_id,
  23. utc_now,
  24. )
  25. from .state_machine import transition
  26. TERMINAL_TASK_STATUSES = {
  27. TaskStatus.COMPLETED,
  28. TaskStatus.CANCELLED,
  29. TaskStatus.SUPERSEDED,
  30. }
  31. ACTIVE_TASK_STATUSES = {
  32. TaskStatus.RUNNING,
  33. TaskStatus.AWAITING_VALIDATION,
  34. TaskStatus.VALIDATING,
  35. }
  36. def path_key(display_path: str) -> Tuple[int, ...]:
  37. """Return a stable numeric sort key for a dotted task display path."""
  38. try:
  39. return tuple(int(part) for part in display_path.split("."))
  40. except ValueError:
  41. return (10**9,)
  42. class TaskGraph:
  43. """Maintain task hierarchy and accepted child-result bindings.
  44. All methods operate on a caller-owned ``TaskLedger``. Keeping persistence
  45. out of this component preserves ``TaskCoordinator`` as the sole writer.
  46. """
  47. @staticmethod
  48. def accepted_child_results(
  49. ledger: TaskLedger,
  50. task: TaskRecord,
  51. attempt: Optional[TaskAttempt] = None,
  52. ) -> List[Dict[str, Any]]:
  53. """Build immutable, accepted direct-child inputs for a parent Worker."""
  54. results: List[Dict[str, Any]] = []
  55. if attempt is None:
  56. decision_ids = TaskGraph.accepted_child_decision_ids(ledger, task)
  57. elif attempt.accepted_child_decision_ids is None:
  58. raise OrchestrationError(
  59. "Attempt has no frozen accepted child decision binding"
  60. )
  61. else:
  62. decision_ids = attempt.accepted_child_decision_ids
  63. if len(set(decision_ids)) != len(decision_ids):
  64. raise OrchestrationError("Attempt child decision bindings are not unique")
  65. expected_decision_ids = TaskGraph.accepted_child_decision_ids(ledger, task)
  66. if tuple(decision_ids) != expected_decision_ids:
  67. raise OrchestrationError(
  68. "Attempt child decision bindings do not match direct children in "
  69. "display_path order"
  70. )
  71. direct_children = set(task.child_task_ids)
  72. prior_path: Optional[Tuple[int, ...]] = None
  73. for decision_id in decision_ids:
  74. decision = ledger.decisions.get(decision_id)
  75. if (
  76. decision is None
  77. or decision.task_id not in direct_children
  78. or decision.action != DecisionAction.ACCEPT
  79. ):
  80. raise OrchestrationError(
  81. "Attempt child decision binding is not a direct-child ACCEPT"
  82. )
  83. child = ledger.tasks[decision.task_id]
  84. child_path = path_key(child.display_path)
  85. if prior_path is not None and child_path < prior_path:
  86. raise OrchestrationError(
  87. "Attempt child decision bindings are not in display_path order"
  88. )
  89. prior_path = child_path
  90. bound_decision, child_attempt, validation = TaskGraph.accepted_result_binding(
  91. ledger, child
  92. )
  93. if bound_decision.decision_id != decision_id:
  94. raise OrchestrationError(
  95. "Attempt child decision binding is not the child's accepted result"
  96. )
  97. results.append(
  98. {
  99. "task_id": child.task_id,
  100. "task_spec": json_values(asdict(child.current_spec)),
  101. "attempt_id": child_attempt.attempt_id,
  102. "snapshot_id": child_attempt.snapshot_id,
  103. "submission": json_values(asdict(child_attempt.submission)),
  104. "validation": {
  105. "validation_id": validation.validation_id,
  106. "summary": validation.summary,
  107. "evidence_refs": json_values(
  108. asdict(validation)["evidence_refs"]
  109. ),
  110. },
  111. }
  112. )
  113. return results
  114. @staticmethod
  115. def accepted_child_decision_ids(
  116. ledger: TaskLedger,
  117. task: TaskRecord,
  118. ) -> Tuple[str, ...]:
  119. decision_ids: List[str] = []
  120. children = sorted(
  121. (ledger.tasks[child_id] for child_id in task.child_task_ids),
  122. key=lambda child: path_key(child.display_path),
  123. )
  124. for child in children:
  125. if child.status == TaskStatus.COMPLETED:
  126. decision, _attempt, _validation = TaskGraph.accepted_result_binding(
  127. ledger, child
  128. )
  129. decision_ids.append(decision.decision_id)
  130. return tuple(decision_ids)
  131. @staticmethod
  132. def root_task(ledger: TaskLedger) -> TaskRecord:
  133. if not ledger.root_task_id:
  134. raise TaskConflict(
  135. "Rootless task ledger is incompatible with mission execution; "
  136. "rebuild the development trace"
  137. )
  138. root = ledger.tasks.get(ledger.root_task_id)
  139. top_level = [
  140. task.task_id
  141. for task in ledger.tasks.values()
  142. if task.parent_task_id is None
  143. ]
  144. if not root or root.parent_task_id is not None or top_level != [root.task_id]:
  145. raise OrchestrationError("Task ledger Root Task structure is invalid")
  146. return root
  147. @staticmethod
  148. def accepted_result_binding(
  149. ledger: TaskLedger,
  150. task: TaskRecord,
  151. ) -> Tuple[PlannerDecision, TaskAttempt, ValidationReport]:
  152. if task.status != TaskStatus.COMPLETED or not task.decision_ids:
  153. raise OrchestrationError(f"Task {task.task_id} has no accepted result")
  154. decision = ledger.decisions.get(task.decision_ids[-1])
  155. if (
  156. not decision
  157. or decision.task_id != task.task_id
  158. or decision.action != DecisionAction.ACCEPT
  159. or not decision.attempt_id
  160. or not decision.validation_id
  161. ):
  162. raise OrchestrationError(
  163. f"Task {task.task_id} has an invalid accept decision"
  164. )
  165. attempt = ledger.attempts.get(decision.attempt_id)
  166. validation = ledger.validations.get(decision.validation_id)
  167. if (
  168. not attempt
  169. or attempt.task_id != task.task_id
  170. or not attempt.submission
  171. or not attempt.snapshot_id
  172. or attempt.spec_version != task.current_spec_version
  173. or not validation
  174. or validation.task_id != task.task_id
  175. or validation.attempt_id != attempt.attempt_id
  176. or validation.snapshot_id != attempt.snapshot_id
  177. or validation.spec_version != task.current_spec_version
  178. or validation.status != ValidationRunStatus.COMPLETED
  179. or validation.verdict != ValidationVerdict.PASSED
  180. ):
  181. raise OrchestrationError(
  182. f"Task {task.task_id} has an invalid accepted result binding"
  183. )
  184. return decision, attempt, validation
  185. @staticmethod
  186. def nonterminal_descendants(
  187. ledger: TaskLedger,
  188. task: TaskRecord,
  189. ) -> List[TaskRecord]:
  190. descendants: List[TaskRecord] = []
  191. pending_ids = list(task.child_task_ids)
  192. while pending_ids:
  193. child = ledger.tasks[pending_ids.pop()]
  194. pending_ids.extend(child.child_task_ids)
  195. if child.status not in TERMINAL_TASK_STATUSES:
  196. descendants.append(child)
  197. return descendants
  198. def create_child_records(
  199. self,
  200. ledger: TaskLedger,
  201. parent: TaskRecord,
  202. drafts: Sequence[Dict[str, Any]],
  203. ) -> List[str]:
  204. return self.create_records(ledger, drafts, parent.task_id, parent.display_path)
  205. def create_sibling_records(
  206. self,
  207. ledger: TaskLedger,
  208. task: TaskRecord,
  209. drafts: Sequence[Dict[str, Any]],
  210. ) -> List[str]:
  211. parent_path = (
  212. ledger.tasks[task.parent_task_id].display_path
  213. if task.parent_task_id
  214. else ""
  215. )
  216. return self.create_records(ledger, drafts, task.parent_task_id, parent_path)
  217. @staticmethod
  218. def add_task_record(
  219. ledger: TaskLedger,
  220. draft: Dict[str, Any],
  221. parent_task_id: Optional[str],
  222. display_path: str,
  223. ) -> str:
  224. task_id = new_id()
  225. spec = TaskGraph.task_spec_from_draft(draft, version=1)
  226. ledger.tasks[task_id] = TaskRecord(
  227. task_id=task_id,
  228. goal_id=None,
  229. parent_task_id=parent_task_id,
  230. display_path=display_path,
  231. specs=[spec],
  232. )
  233. return task_id
  234. @staticmethod
  235. def task_spec_from_draft(draft: Dict[str, Any], *, version: int) -> TaskSpec:
  236. if not isinstance(draft, dict):
  237. raise ValueError("Task draft must be an object")
  238. return TaskSpec.from_dict(
  239. {
  240. "version": version,
  241. "objective": draft.get("objective", ""),
  242. "acceptance_criteria": draft.get("acceptance_criteria", []),
  243. "context_refs": draft.get("context_refs", ()),
  244. }
  245. )
  246. def create_records(
  247. self,
  248. ledger: TaskLedger,
  249. drafts: Sequence[Dict[str, Any]],
  250. parent_task_id: Optional[str],
  251. parent_path: str,
  252. ) -> List[str]:
  253. siblings = sorted(
  254. (
  255. task
  256. for task in ledger.tasks.values()
  257. if task.parent_task_id == parent_task_id
  258. ),
  259. key=lambda item: path_key(item.display_path),
  260. )
  261. created: List[str] = []
  262. for offset, draft in enumerate(drafts, start=1):
  263. index = len(siblings) + offset
  264. display_path = f"{parent_path}.{index}" if parent_path else str(index)
  265. task_id = self.add_task_record(
  266. ledger,
  267. draft,
  268. parent_task_id,
  269. display_path,
  270. )
  271. if parent_task_id:
  272. ledger.tasks[parent_task_id].child_task_ids.append(task_id)
  273. created.append(task_id)
  274. return created
  275. @staticmethod
  276. def mark_parent_waiting(parent: TaskRecord) -> None:
  277. if parent.status == TaskStatus.WAITING_CHILDREN:
  278. return
  279. transition(parent.status, TaskStatus.WAITING_CHILDREN)
  280. parent.status = TaskStatus.WAITING_CHILDREN
  281. parent.updated_at = utc_now()
  282. @staticmethod
  283. def update_parent_after_child(ledger: TaskLedger, child: TaskRecord) -> None:
  284. if not child.parent_task_id or child.status not in TERMINAL_TASK_STATUSES:
  285. return
  286. parent = ledger.tasks[child.parent_task_id]
  287. if parent.status != TaskStatus.WAITING_CHILDREN:
  288. return
  289. children = [ledger.tasks[child_id] for child_id in parent.child_task_ids]
  290. if children and all(
  291. candidate.status in TERMINAL_TASK_STATUSES for candidate in children
  292. ):
  293. transition(parent.status, TaskStatus.NEEDS_REPLAN)
  294. parent.status = TaskStatus.NEEDS_REPLAN
  295. parent.updated_at = utc_now()
  296. @staticmethod
  297. def display_path(
  298. ledger: TaskLedger,
  299. parent_task_id: Optional[str],
  300. index: int,
  301. ) -> str:
  302. if not parent_task_id:
  303. return str(index)
  304. return f"{ledger.tasks[parent_task_id].display_path}.{index}"
  305. @staticmethod
  306. def rebase_task_path(
  307. ledger: TaskLedger,
  308. task: TaskRecord,
  309. display_path: str,
  310. ) -> None:
  311. task.display_path = display_path
  312. for index, child_id in enumerate(task.child_task_ids, start=1):
  313. TaskGraph.rebase_task_path(
  314. ledger,
  315. ledger.tasks[child_id],
  316. f"{display_path}.{index}",
  317. )
  318. __all__ = [
  319. "ACTIVE_TASK_STATUSES",
  320. "TERMINAL_TASK_STATUSES",
  321. "TaskGraph",
  322. "path_key",
  323. ]