Просмотр исходного кода

Enable creative approval image previews by default

刘立冬 3 недель назад
Родитель
Сommit
ee9bf058e0

+ 2 - 2
examples/auto_put_ad_mini/PRODUCTION_AUTOMATION.md

@@ -301,10 +301,10 @@ CREATION_ONLY_CROWD_PACKAGES=回流330以上人群
 
 
 创意审批表包含独立的 `素材预览` 和 `素材链接` 两列:`素材预览` 用于图片/查看入口,`素材链接` 保留原始素材 URL 的 `HYPERLINK` 公式。当前 `决策` 列为 `AB`,审批轮询也读取 `AB` 列。
 创意审批表包含独立的 `素材预览` 和 `素材链接` 两列:`素材预览` 用于图片/查看入口,`素材链接` 保留原始素材 URL 的 `HYPERLINK` 公式。当前 `决策` 列为 `AB`,审批轮询也读取 `AB` 列。
 
 
-若需要把素材封面作为缩略图嵌入 xlsx 后再上传飞书在线表格,可临时开启:
+素材封面默认会作为缩略图嵌入 xlsx 后再上传飞书在线表格。若需要临时关闭嵌图,可设置:
 
 
 ```bash
 ```bash
-CREATION_APPROVAL_EMBED_IMAGES=1
+CREATION_APPROVAL_EMBED_IMAGES=0
 ```
 ```
 
 
 飞书导入若不保留 xlsx 内嵌图片,审批表仍保留链接兜底;后续可改用飞书 Sheets 写图片 API。
 飞书导入若不保留 xlsx 内嵌图片,审批表仍保留链接兜底;后续可改用飞书 Sheets 写图片 API。

+ 11 - 0
examples/auto_put_ad_mini/test_im_approval_creation.py

@@ -1,7 +1,10 @@
+import importlib
+import os
 import sys
 import sys
 import unittest
 import unittest
 from pathlib import Path
 from pathlib import Path
 from tempfile import TemporaryDirectory
 from tempfile import TemporaryDirectory
+from unittest.mock import patch
 
 
 from openpyxl import load_workbook
 from openpyxl import load_workbook
 
 
@@ -13,6 +16,7 @@ from tools.im_approval_creation import (  # noqa: E402
     DECISION_COL_LETTER,
     DECISION_COL_LETTER,
     generate_approval_xlsx,
     generate_approval_xlsx,
 )
 )
+import tools.im_approval_creation as approval_module  # noqa: E402
 
 
 
 
 def _sample_record() -> dict:
 def _sample_record() -> dict:
@@ -39,6 +43,13 @@ def _sample_record() -> dict:
 
 
 
 
 class CreativeApprovalSheetTest(unittest.TestCase):
 class CreativeApprovalSheetTest(unittest.TestCase):
+    def test_embeds_material_preview_images_by_default(self):
+        with patch.dict(os.environ, {}, clear=False):
+            os.environ.pop("CREATION_APPROVAL_EMBED_IMAGES", None)
+            reloaded = importlib.reload(approval_module)
+
+        self.assertTrue(reloaded.EMBED_MATERIAL_PREVIEW_IMAGES)
+
     def test_keeps_dedicated_material_link_column(self):
     def test_keeps_dedicated_material_link_column(self):
         with TemporaryDirectory() as tmp:
         with TemporaryDirectory() as tmp:
             output = Path(tmp) / "approval.xlsx"
             output = Path(tmp) / "approval.xlsx"

+ 1 - 1
examples/auto_put_ad_mini/tools/im_approval_creation.py

@@ -79,7 +79,7 @@ COL_WIDTHS = {
 DECISION_COL_LETTER = "AB"
 DECISION_COL_LETTER = "AB"
 VALID_ACTIONS = ("approve", "reject", "hold")
 VALID_ACTIONS = ("approve", "reject", "hold")
 EMBED_MATERIAL_PREVIEW_IMAGES = os.getenv(
 EMBED_MATERIAL_PREVIEW_IMAGES = os.getenv(
-    "CREATION_APPROVAL_EMBED_IMAGES", ""
+    "CREATION_APPROVAL_EMBED_IMAGES", "1"
 ).strip().lower() in {"1", "true", "yes", "y", "on"}
 ).strip().lower() in {"1", "true", "yes", "y", "on"}
 MATERIAL_PREVIEW_COL_IDX = 15
 MATERIAL_PREVIEW_COL_IDX = 15
 MATERIAL_PREVIEW_COL_LETTER = "O"
 MATERIAL_PREVIEW_COL_LETTER = "O"