Procházet zdrojové kódy

Refactor: Remove unused normalizeAdProfessionName method and calls

jiandong.liu před 3 týdny
rodič
revize
3f2693aa9f

+ 0 - 1
ad-engine-service/src/main/java/com/tzld/piaoquan/ad/engine/service/score/strategy/FeaturePrinterStrategy.java

@@ -18,7 +18,6 @@ import java.util.Set;
 public class FeaturePrinterStrategy extends RankStrategyBasic {
     @Override
     public List<AdRankItem> adItemRank(RankRecommendRequestParam request, ScoreParam scoreParam) {
-        normalizeAdProfessionName(request);
         Set<String> noApiAdVerIds = getNoApiAdVerIds();
         long ts = System.currentTimeMillis() / 1000;
 

+ 0 - 14
ad-engine-service/src/main/java/com/tzld/piaoquan/ad/engine/service/score/strategy/RankStrategyBasic.java

@@ -358,7 +358,6 @@ public abstract class RankStrategyBasic implements RankStrategy {
     }
 
     protected void filterRequestAdList(RankRecommendRequestParam request, ScoreParam scoreParam) {
-        normalizeAdProfessionName(request);
         Map<String, String> userLayer = this.getUserLayer(request.getMid());
         String layer;
         String clazz;
@@ -432,19 +431,6 @@ public abstract class RankStrategyBasic implements RankStrategy {
         }
     }
 
-    protected void normalizeAdProfessionName(RankRecommendRequestParam request) {
-        if (request == null || CollectionUtils.isEmpty(request.getAdIdList())) {
-            return;
-        }
-        // adProfessionName 覆盖 profession(上游逐步废弃 profession,统一用 adProfessionName)
-        for (AdPlatformCreativeDTO dto : request.getAdIdList()) {
-            if (StringUtils.isNotBlank(dto.getAdProfessionName())) {
-                dto.setProfession(dto.getAdProfessionName());
-            }
-        }
-    }
-
-
     protected boolean getIsGuaranteedFlow(ScoreParam scoreParam) {
         // 817实验不要保量
         if (scoreParam.getEngineInfo() != null && "817".equals(scoreParam.getEngineInfo().get("model"))) {

+ 0 - 1
ad-engine-service/src/main/java/com/tzld/piaoquan/ad/engine/service/score/strategy/RankStrategyByWeight.java

@@ -22,7 +22,6 @@ public class RankStrategyByWeight extends RankStrategyBasic {
 
     @Override
     public List<AdRankItem> adItemRank(RankRecommendRequestParam request, ScoreParam scoreParam) {
-        normalizeAdProfessionName(request);
         Set<String> noApiAdVerIds = getNoApiAdVerIds();
 
         List<AdPlatformCreativeDTO> creativeDTOS = request.getAdIdList();