修改校验空值

pqai_agent_server/api_server.py

@@ -685,7 +685,7 @@ def get_test_task_conversations():
        :return:
     """
     task_id = request.args.get("taskId", None)
-    if not task_id:
+    if task_id is None:
         return wrap_response(404, msg='task_id is required')
     page_num = request.args.get("pageNum", const.DEFAULT_PAGE_ID)
     page_size = request.args.get("pageSize", const.DEFAULT_PAGE_SIZE)
@@ -708,12 +708,12 @@ def create_test_task():
     agent_id = req_data.get('agentId', None)
     module_id = req_data.get('moduleId', None)
     evaluate_type = req_data.get('evaluateType', None)
-    if not agent_id:
+    if agent_id is None:
         return wrap_response(404, msg='agent id is required')
-    if not module_id:
+    if module_id is None:
         return wrap_response(404, msg='module id is required')
-    if not evaluate_type:
-        return wrap_response(404, msg='evaluate_type id is required')
+    if evaluate_type is None:
+        return wrap_response(404, msg='evaluate type id is required')
     app.task_manager.create_task(agent_id, module_id, evaluate_type)
     return wrap_response(200)
 
@@ -727,10 +727,10 @@ def stop_test_task():
     req_data = request.json
     task_id = req_data.get('taskId', None)
     if not task_id:
-        return wrap_response(400, msg='task id is required')
+        return wrap_response(404, msg='task id is required')
     task = app.task_manager.get_task(task_id)
     if task.status not in (TestTaskStatus.NOT_STARTED.value, TestTaskStatus.IN_PROGRESS.value):
-        return wrap_response(400, msg='task status is invalid')
+        return wrap_response(404, msg='task status is invalid')
     app.task_manager.cancel_task(task_id)
     return wrap_response(200)
 
@@ -743,11 +743,11 @@ def resume_test_task():
     """
     req_data = request.json
     task_id = req_data.get('taskId', None)
-    if not task_id:
-        return wrap_response(400, msg='task id is required')
+    if task_id is None:
+        return wrap_response(404, msg='task id is required')
     task = app.task_manager.get_task(task_id)
     if task.status != TestTaskStatus.CANCELLED.value:
-        return wrap_response(400, msg='task status is invalid')
+        return wrap_response(404, msg='task status is invalid')
     app.task_manager.resume_task(task_id)
     return wrap_response(200)
 
@@ -791,7 +791,7 @@ def get_conversation_data_list():
        :return:
     """
     dataset_id = request.args.get("datasetId", None)
-    if not dataset_id:
+    if dataset_id is None:
         return wrap_response(404, msg='dataset_id is required')
     page_num = request.args.get("pageNum", const.DEFAULT_PAGE_ID)
     page_size = request.args.get("pageSize", const.DEFAULT_PAGE_SIZE)
@@ -813,9 +813,9 @@ def create_agent_task():
     req_data = request.json
     agent_id = req_data.get('agentId', None)
     task_prompt = req_data.get('taskPrompt', None)
-    if not agent_id:
+    if agent_id is None:
         return wrap_response(404, msg='agent id is required')
-    if not task_prompt:
+    if task_prompt is None:
         return wrap_response(404, msg='task_prompt is required')
     app.agent_task_manager.create_task(agent_id, task_prompt)
     return wrap_response(200)
@@ -844,7 +844,7 @@ def get_agent_task_detail():
        :return:
     """
     agent_task_id = request.args.get("agentTaskId", None)
-    if not agent_task_id:
+    if agent_task_id is None:
         return wrap_response(404, msg='agent_task_id is required')
     parent_execution_id = request.args.get("parentExecutionId", None)
     response = app.agent_task_manager.get_agent_task_detail(int(agent_task_id), parent_execution_id)